refactor(harness): model coding harness contracts - #232
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Waishnav
changed the title
Greptile SummaryThe PR refactors legacy tool-mode configuration into a composed harness model while preserving the existing environment-variable interface and per-mode tool behavior.
Confidence Score: 5/5The PR appears safe to merge with legacy configuration inputs and tool contracts preserved. The new harness variants map exactly to the previous minimal, full, and codex behavior, all server predicates remain equivalent for constructible configurations, and no stale ServerConfig.toolMode consumers remain.
|
| Filename | Overview |
|---|---|
| src/config.ts | Replaces the legacy runtime toolMode field with a harness configuration while preserving legacy environment parsing. |
| src/harness.ts | Introduces the closed harness configuration union, legacy-mode mapping, and dedicated-inspection capability predicate. |
| src/server.ts | Uses harness kind and inspection capability to preserve existing instructions and conditional tool registration. |
| src/config.test.ts | Verifies all legacy tool-mode and minimal-tools inputs map to the intended harness configurations. |
| src/server.test.ts | Verifies the exact registered tool set for minimal, full, and codex legacy modes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Env["Legacy DEVSPACE_TOOL_MODE"] --> Parse["parseLegacyToolMode"]
Parse --> Map["harnessFromLegacyToolMode"]
Map --> Minimal["Claude Code / shell inspection"]
Map --> Full["Claude Code / dedicated inspection"]
Map --> Codex["Codex harness"]
Minimal --> Tools["Tool registration and instructions"]
Full --> Tools
Codex --> Tools
Reviews (1): Last reviewed commit: "test(harness): lock tool contracts" | Re-trigger Greptile
|
Closing this stacked PR because the v1.1 configuration/runtime refactor is being collapsed into one review PR. The commits are preserved in the combined branch. |
|
Superseded by the combined v1.1 refactor PR #238. |
1 participant
The existing minimal, full, and codex mode names mix harness selection with inspection behavior and force the server to reinterpret them repeatedly. This layer introduces an explicit Claude Code or Codex coding harness model, maps the legacy tool-mode environment values into it, and pins the exact tool contracts for each existing mode.
Stacked on #231. No user-facing tool-surface change is intended in this layer.
Stack created with GitHub Stacks CLI • Give Feedback 💬